Repository navigation
[O2B-1361] Remove DPL notion from detectors - #1991
Merged
graduta merged 16 commits intoOct 22, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1991 +/- ##
==========================================
+ Coverage 46.31% 46.34% +0.03%
==========================================
Files 1050 1050
Lines 17367 17367
Branches 3168 3168
==========================================
+ Hits 8043 8049 +6
+ Misses 9324 9318 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xsalonx
marked this pull request as ready for review
September 24, 2025 00:12
graduta
changed the title
…nx/O2B-1361/remove-dpl-notion-from-detectors
4 tasks done
- `POST /api/qcFlags` test added on main (QC flag creation with `verify`) still sent `dplDetectorId`, which the API no longer accepts: use `detectorId` - Rename `GaqDetectorsService._verifyRunsAndDplDetectorsAssociations` to `_verifyRunsAndDetectorsAssociations` - Restore the `DplDetector` and `DplDetectorIdentifier` typedefs: they were deleted but are still used by the DPL process code (service, adapter, run details panel)
…ve-dpl-notion-from-detectors
graduta
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: